[Intel-gfx] [PATCH] drm/i915: Decode RING_BUFFER_HEAD in error state

[Daniel Vetter]

On Mon, Apr 22, 2013 at 02:16:34PM +0100, Chris Wilson wrote:
> On Sun, Apr 21, 2013 at 04:01:19PM -0700, Ben Widawsky wrote:
> > I consistently forget how to decode the HEAD pointer. If we put it in
> > the error state, one doesn't need to look in docs to find the relevant
> > info.
> > 
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> Turn the offset into an address and that would be really useful - then
> once can do a quick search on the value and jump straight into the right
> point in the ring.
>   error->head[ring] & (0x7ffff << 2) + error->ring[ring].batchbuffer->gtt_offset

Also, shouldn't that kind of decode magic be done in intel_error_decode,
where we have all the other stuff? Or is there a special reason?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch