[Intel-gfx] [PATCH] drm/i915: init hardware to a known state on resume v3

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 24 11:22:20 CEST 2013


On Tue, Apr 23, 2013 at 03:46:41PM -0700, Jesse Barnes wrote:
> From: Zou Nanhai <nanhai.zou at intel.com>
> 
> Needed on SNB to avoid some RC6 related hangs.

IIRC, the wa was not for a hang, but for render corruption.

> v2: remove unneeded defines (Ken)
> v3: update to agp-less driver (Jesse)
>     fixup for new GEM APIs (Jesse)
>     make debugfs use new locking (Jesse)
> 
> Signed-off-by: Zou Nanhai <nanhai.zou at intel.com>
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Hmm, why do you want to emit gen6 state on gen7+? Please tidy up the
state emission, it is very very ugly, contains lots of redundancy and
some interesting choice of hard coded magic. The emit_wa() flush/idle
sequence doesn't do what you want, whereas emit_rect() does.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list