[Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 24 11:35:16 CEST 2013


On Wed, Apr 24, 2013 at 11:19:20AM +0200, Daniel Vetter wrote:
> Our rps code relies on the interrupts being off to prevent re-arming
> of the work items at inopportune moments.
> 
> Also drop the redundant cancel_work for the main rps work,
> disable_gt_powersave already takes care of that.
> 
> Finally add a WARN_ON to ensure we obey that piece of ordering
> constraint. Long term I want to lock down the setup/teardown code in a
> similar way to how we painstakingly check modeset sequence constraints
> already.

Reminds me, did we every get around to flushing our deferred hw tasks
upon suspend? I've a funny feeling that is still missing.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list