[Intel-gfx] [PATCH 7/7] drm/i915: simplify config->pixel_multiplier handling

Daniel Vetter daniel at ffwll.ch
Thu Apr 25 21:22:43 CEST 2013


On Thu, Apr 25, 2013 at 03:08:32PM +0300, Ville Syrjälä wrote:
> On Fri, Apr 19, 2013 at 11:14:37AM +0200, Daniel Vetter wrote:
> > We only ever check whether it's strictly bigger than one, so all the
> > is_sdvo/is_hdmi checks are redundant. Flatten the code a bit.
> > 
> > Also, s/temp/dpll_md/
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> 
> Looks OK. Note that we actually never set pixel_multipler on VLV since
> it doesn't support SDVO, but supposedly it could be used for HDMI too.
> So I guess it doesn't hurt to keep the code for it.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Merged the entire series, with the commit message for patch 3 massively
pimped with my follow up. Thanks a lot for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list