[Intel-gfx] [PATCH 6/8] drm/i915/hmdi: Rename set_infoframe() to write_infoframe()

[Damien Lespiau]

On Tue, Aug 06, 2013 at 08:01:34PM +0200, Daniel Vetter wrote:
> On Tue, Aug 6, 2013 at 7:49 PM, Damien Lespiau <damien.lespiau at intel.com> wrote:
> > On Mon, Aug 05, 2013 at 08:50:45PM +0300, Ville Syrjälä wrote:
> >> On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote:
> >> > set_frame() wraps the write_frame() vfunc. Be consistent and name the
> >> > wrapping function like the vfunc being called.
> >> >
> >> > It's doubly confusing as we also have a set_infoframes() vfunc and
> >> > set_infoframe() doesn't wrap it.
> >>
> >> I guess the logic was
> >>  set_infoframes -> set_<type>_infoframe -> set_infoframe -> write_infoframe
> >>
> >> But I don't really have an opinion on which is better, so:
> >
> > Meh, doesn't really matter :) I'll just drop this patch.
> 
> I think it makes sense and more clearly distinguishes set_infoframes
> from from writing them. So would have merged ...

Will resend with the new series then :)

-- 
Damien