[Intel-gfx] [PATCH 11/13] drm/i915: Don't try to disable plane if it's already disabled

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 6 22:29:15 CEST 2013


On Tue, Aug 06, 2013 at 10:24:10PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Check plane->fb in intel_disable_plane() to determine if the plane
> is already disabled.
> 
> If the plane has an fb, then it must also have a crtc, so we can drop
> the plane->crtc check and just call intel_enable_primary() directly.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Leave it in as a if (WARN(plane->crtc)) return -EINVAL;
I don't think this is performance critical and it serves as a good
reminder.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list