[Intel-gfx] [PATCH 03/13] drm/i915: Split watermark level computation from the code

[Chris Wilson]

On Tue, Aug 06, 2013 at 10:24:02PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Refactor the watermarks computation for one level to a separate
> function. This function will now set the ->enable flat to true,

s/flat/flag/

Though I did think you meant a flatten value at one point.

> even if the watermark level wasn't actually checked yet. In the
> future we will delay the checking so we must consider all unchecked
> watermarks as possibly valid.
> 
> v2: Preserve comment about latency units
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

I don't have the context here to confirm passing level to
ilk_compute_pri_wm is exactly what you want, and it seems that level is
implicitly greater than 0 in the original code.

The transformation looks fine by itself. If you can calm my quirms over
the value of level (in the changelog is fine),
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre