[Intel-gfx] [PATCH 7/9] drm/i915: allow package C8+ states on Haswell (disabled)

[Chris Wilson]

On Tue, Aug 06, 2013 at 06:57:17PM -0300, Paulo Zanoni wrote:
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index 2ef4335..7f6ec9e 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -1590,6 +1590,8 @@ void intel_ring_advance(struct intel_ring_buffer *ring)
>  {
>  	struct drm_i915_private *dev_priv = ring->dev->dev_private;
>  
> +	hsw_package_c8_gpu_busy(dev_priv);
> +

Ahem, what is this doing here? If only we had something that was the
opposite of intel_mark_idle... At this point, I am going to get some
sleep...

Overall it looks much, much better. I am still uneasy about the
interrupt race whilst disabling them, so I need to think some more about
that. The new DRM_ERRORs should be WARN and a few other minor niggles. I
really do like the new names though, thanks.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre