[Intel-gfx] [PATCH 1/2] drm/i915: Eliminate unrequired dwords for MI_SET_CONTEXT

[Chris Wilson]

On Fri, Aug 09, 2013 at 11:41:26AM +0200, Daniel Vetter wrote:
> On Thu, Aug 08, 2013 at 08:00:25PM +0100, Chris Wilson wrote:
> > A later patch adds yet another workaround for MI_SET_CONTEXT, at which
> > point we start to end up with more NOOPs than actual command dwords
> > along the non-workaround paths. It is time that we made the MI_SET_CONTEXT
> > a variable length block and only emit the dwords we truly need.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> 
> Since this seems to be based on top of gen5 context support: Care to slap
> an r-b and tested-by onto it so that I can merge the entire shebang?

Sure, there was nothing outrageous in the enabling patches, and I can
confirm that in the end none of the symptoms I had were related to
context enabling (just the machine dying as it turns out).

So for the ilk ctx patches:

The i915_gem_obj_ggtt_pin() changes are ultimately bogus, that is
  drm/i915: Make ILK context objects more like the others
and
  drm/i915: Restore ILK powerctx pin attributes
cancel each other out and can quite happily die. What would be nice
would be to use
  i915_gem_object_ggtt_pin(ctx, 0, false, false);
instead.

All the other patches look good, so
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

And a Tested-by: Chris Wilson <chris at chris-wilson.co.uk> # X still works!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre