[Intel-gfx] [PATCH 7/9] drm/i915: allow package C8+ states on Haswell (disabled)

Paulo Zanoni przanoni at gmail.com
Fri Aug 9 23:34:56 CEST 2013


2013/8/9 Chris Wilson <chris at chris-wilson.co.uk>:
> Quick note...
>
> On Fri, Aug 09, 2013 at 05:10:05PM -0300, Paulo Zanoni wrote:
>> +     WARN_ON(!mutex_is_locked(&dev_priv->pc8.lock));
>
> Preferred form is now lockdep_assert_held(&dev_priv->pc8.lock);

Should I also convert all our other usages of
WARN_ON(!mutex_is_locked()) and BUG_ON(!mutex_is_locked()) too? On a
separate patch, of course. We have currently no usage of
lockdep_assert_held, and I like consistency, so fully switching to the
preferred form is good IMHO.

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list