[Intel-gfx] [PATCH 2/2] drm/i915: drop unnecessary local variable to suppress build warning

[Kees Cook]

On Sun, Aug 11, 2013 at 3:15 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sun, Aug 11, 2013 at 10:50:17AM +0100, Chris Wilson wrote:
>> On Sun, Aug 11, 2013 at 12:44:02PM +0300, Jani Nikula wrote:
>> > Although I could not reproduce this (different compiler version,
>> > perhaps), reportedly we get:
>> >
>> > drivers/gpu/drm/i915/i915_irq.c:1943:27: warning: ‘score’ may be used
>> > uninitialized in this function [-Wuninitialized]
>> >
>> > Drop the 'score' variable altogether as it's not really needed.
>>
>> Right, it was only there because I thought the switch was more readable
>> with the temporary.
>>
>> > Reported-by: Kees Cook <keescook at chromium.org>
>> Go fix your compiler!
>
> Indeed, Kees seems to have an especially dense bread of gcc ;-)

4.6.3! :P What're you all using? (Regardless, I'm looking forward to 4.9.)

>> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>> Both patches
>> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
>
> Both merged to dinq, thanks for the patches and review.

Cool. My stderr during compilation thanks you. :)

-Kees

-- 
Kees Cook
Chrome OS Security