[Intel-gfx] [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts

Daniel Vetter daniel at ffwll.ch
Tue Aug 13 16:04:44 CEST 2013


On Tue, Aug 13, 2013 at 02:39:55PM +0100, Chris Wilson wrote:
> On Tue, Aug 13, 2013 at 10:36:04AM -0300, Rodrigo Vivi wrote:
> > applied to experimental drm-intel-collector.
> > 
> > drivers/gpu/drm/i915/i915_gem.c: In function ‘__wait_seqno’:
> > drivers/gpu/drm/i915/i915_gem.c:1033:20: warning: ‘timeout_jiffies’ may be used
> > +uninitialized in this function
> 
> Dumb gcc.
> 
> Note the lack of sign-off. Ben would hate this patch since it may unmask
> simulator bugs.

Hm, I'd prefer it with sob line since I very much want to again have good
reporting on missed interrupts (instead of silently papering over them).
If the simulator is broken we need to apply special duct-tape for it
(maybe in the form of a timer that regularly checks the seqno), since 1s
delay is simply too slow, even for simulators.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list