[Intel-gfx] [PATCH] drm/i915: inline vma_create into lookup_or_create_vma

Daniel Vetter daniel at ffwll.ch
Wed Aug 14 14:08:54 CEST 2013


On Wed, Aug 14, 2013 at 12:49:04PM +0100, Chris Wilson wrote:
> On Wed, Aug 14, 2013 at 11:59:09AM +0200, Daniel Vetter wrote:
> > In the execbuf code we don't clean up any vmas which ended up not
> > getting bound for code simplicity. To make sure that we don't end up
> > creating multiple vma for the same vm kill the somewhat dangerous
> > vma_create function and inline it into lookup_or_create.
> 
> Just make it static. It's a nice little standalone function that helps
> the reader.

I'm afraid that someone will use it eventually. I'll smash a __ prefix
onto it to make it clear that people better don't touch it.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list