[Intel-gfx] [igt PATCH 4/4] tests: add kms_setmode

[Imre Deak]

On Tue, 2013-08-06 at 11:23 +0200, Daniel Vetter wrote:
> On Mon, Aug 05, 2013 at 02:45:26PM +0300, Imre Deak wrote:
> > Iterate through all valid/invalid crtc/connector combinations. At the
> > moment only clone configurations are tested as the single output cases
> > are tested already by testdisplay. Also from combinations where all
> > connectors are on the same crtc (clone-single-crtc) only those are
> > tested that are invalid, as I haven't found any machine that supports
> > these (have to be GT2 with dvo and vga output).
> > 
> > For configurations with one crtc per connector the FBs are per-crtc atm.
> > 
> > Signed-off-by: Imre Deak <imre.deak at intel.com>
> 
> lgtm. Please push as soon as we've figured out what to do with patch 3.
> 
> I wonder whether we shouldn't change our DP code a bit and force the
> port into normal mode (with some conservative link training values) even
> when link training fails. Contrary to fdi links I think the pixels would
> still flow and so would allow us to exercise more codepaths. But that's
> for another time I guess.

Yes, for testing purposes allowing the pipe to be on even on
disconnected DP would be nice. The same for other disconnected
connectors worked out quite well for me w/o all the required displays.

> Depending upon how the kms_ tests shape up we might want to extract a bit
> more code from here, but again we can do that later.

Yep, agreed as a next step.

--Imre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20130816/1da91df2/attachment.sig>