[Intel-gfx] [PATCH] drm/i915: Track the proc which created the context

[Daniel Vetter]

On Thu, Aug 29, 2013 at 3:31 AM, Ben Widawsky
<benjamin.widawsky at intel.com> wrote:
> We've tried more than once in the past to print the guilty process.
> Prior to Mika's recent work however, we never had a good way to actually
> assign guilt. With that, this trivial patch should get print the guilty
> process and pid in dmesg.
>
> Until we merge the full PPGTT support (which have per fd contexts), we
> don't have a good way to name the default context used by X, and other
> clients not opting in to contexts. As such, they will get "swapper" as
> their guilty process. Once the full PPGTT support is merged, we should
> be able to properly track the names.
>
> NOTE: The string is limited to 16 characters as defined by the ASCII
> string kept in the task struct. One could theoretically pull out the
> full from the command args as done for cmdline in proc, but this is
> terribly ugly, and a homework assignment for another day.
>
> Example courtesy of Eric:
> [drm:i915_set_reset_status] *ERROR* render ring hung inside bo (0x1b5a000 ctx 1 [ext_framebuffer pid=5762]) at 0x1b5a034
>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Tested-by: Eric Anholt <eric at anholt.net>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

This is neat. But while at it I think we should add the same
information to the error state, too. Care to quickly update your
patch?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch