[Intel-gfx] [PATCH 1/8] drm/i915: Synchronize pread/pwrite with wait_rendering

Ben Widawsky ben at bwidawsk.net
Sat Aug 31 05:39:46 CEST 2013


On Sat, Aug 31, 2013 at 12:50:30AM +0100, Chris Wilson wrote:
> On Fri, Aug 30, 2013 at 04:43:54PM -0700, Ben Widawsky wrote:
> > lifted from Daniel:
> > pread/pwrite isn't about the object's domain at all, but purely about
> > synchronizing for outstanding rendering. Replacing the call to
> > set_to_gtt_domain with a wait_rendering would imo improve code
> > readability. Furthermore we could pimp pread to only block for
> > outstanding writes and not for reads.
> > 
> > Since you're not the first one to trip over this: Can I volunteer you
> > for a follow-up patch to fix this?
> > 
> > Recommended-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> This should fail i-g-t...
> -Chris
> 

Daniel, how have I failed your plan?

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list