[Intel-gfx] [PATCH] drm/i915: dont call irq_put when irq test is on

Daniel Vetter daniel at ffwll.ch
Thu Dec 12 17:46:47 CET 2013


On Thu, Dec 12, 2013 at 06:06:16PM +0200, Ville Syrjälä wrote:
> On Thu, Dec 12, 2013 at 05:54:42PM +0200, Mika Kuoppala wrote:
> > If test is running, irq_get was not called so we should gain
> > balance by not doing irq_put
> > 
> > "So the rule is: if you access unlocked values, you use ACCESS_ONCE().
> > You don't say "but it can't matter". Because you simply don't know."
> > -- Linus
> > 
> > v2: use local variable so it can't change during test (Chris)
> > 
> > v3: update commit msg and use ACCESS_ONCE (Ville)
> > 
> > Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
> 
> Looks good.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list