[Intel-gfx] [PATCH 2/8] drm/i915: Always use INTEL_INFO() to access the device_info structure

Damien Lespiau damien.lespiau at intel.com
Thu Dec 12 18:05:18 CET 2013


On Thu, Dec 12, 2013 at 04:58:21PM +0000, Chris Wilson wrote:
> On Thu, Dec 12, 2013 at 02:36:37PM +0000, Damien Lespiau wrote:
> > If we make sure that all the dev_priv->info usages are wrapped by
> > INTEL_INFO(), we can easily modify the ->info field to be structure and
> > not a pointer while keeping the const protection in the INTEL_INFO()
> > macro.
> 
> Yuck.

Would Jani's suggestion to transmogrify INTEL_INFO() into a function
make you happier? Or is it the back and forth from *dev_priv to *dev
to dev_priv->info that is of utmost disgust?

-- 
Damien



More information about the Intel-gfx mailing list