[Intel-gfx] [PATCH 1/6] drm/i915: unconditionally copy mode into crtc at boot time

[Jesse Barnes]

On Thu, 12 Dec 2013 22:21:29 +0100
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Thu, Dec 12, 2013 at 12:41:52PM -0800, Jesse Barnes wrote:
> > The BIOS code will need this to properly inherit the mode.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index af3717a..1ae3d44 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -11175,7 +11175,7 @@ void intel_modeset_setup_hw_state(struct drm_device *dev,
> >  	 */
> >  	list_for_each_entry(crtc, &dev->mode_config.crtc_list,
> >  			    base.head) {
> > -		if (crtc->active && i915_fastboot) {
> > +		if (crtc->active) {
> 
> That's just enabling half of the fastboot hack, so nacked.

This part isn't the hack, but is required for fastboot.  Without this,
we'll end up with a bogus mode when we try to inherit from the BIOS.
So if you want to nack this I'll have to put the other BIOS bits under
fastboot as well.

-- 
Jesse Barnes, Intel Open Source Technology Center