[Intel-gfx] [PATCH 6/6] drm/i915: inform drm_fb_helper if we abandoned a connected output
Jesse Barnes
jbarnes at virtuousgeek.org
Thu Dec 12 23:34:18 CET 2013
On Thu, 12 Dec 2013 22:30:41 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Thu, Dec 12, 2013 at 12:41:57PM -0800, Jesse Barnes wrote:
> > Otherwise subsequent fb activity will try to do blank/unblank on outputs
> > that were never fully enabled.
>
> Hmm, actually this highlights a bug in drm_setup_crtcs() that we do not
> reconstruct enabled[] after a return false here.
>
> Only the first enabled[i] = false is required where we continue rather
> than abort.
Yeah this one took me awhile to find. Not surprised if there are other
bugs lurking here. This one fixes the issue introduced by these
patches at least in the multihead config.
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list