[Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

Chris Wilson chris at chris-wilson.co.uk
Sat Dec 14 10:05:03 CET 2013


On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote:
> Add_request has always contained both the semaphore mailbox updates as
> well as the breadcrumb writes. Since the semaphore signal is the one
> which actually knows about the number of dwords it needs to emit to the
> ring, we move the ring_begin to that function. This allows us to remove
> the hideously shared #define

We can now just split it up and use two intel_ring_begin(). And there is
no reason not to pack the semaphore commands tightly.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list