[Intel-gfx] [PATCH 5/6] drm/i915/vlv: move DPIO init earlier v2

Jesse Barnes jbarnes at virtuousgeek.org
Tue Dec 17 01:02:38 CET 2013


On Sat, 14 Dec 2013 11:47:36 +0100
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Thu, Dec 12, 2013 at 12:41:56PM -0800, Jesse Barnes wrote:
> > It's needed for early mode state readout, which is in turn needed to
> > inherit the BIOS config.  So split out the reset, which we need on
> > resume too, from the DPIO reg init, and do the latter earlier.
> > 
> > v2: split reset and reg init
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> Isn't this a fixup due to the slight init reordering you do in patch 2? If
> so we need to get this one in first, and I'd also prefer if the init
> reordering is split out as a separate patch from patch 2 - that stuff
> almost always ends up hurting us in some way or the order, so a minimal
> patch as an obvious bisect point is imo worth it.
> 
> With those prep patches split out I could also start merging to get this
> sucker moving finally.

Sure, done.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list