[Intel-gfx] [PATCH 6/8] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

[Daniel Vetter]

On Tue, Dec 17, 2013 at 10:05 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
>> On Mon, Dec 16, 2013 at 04:34:27PM -0800, Jesse Barnes wrote:
>> > @@ -333,7 +535,8 @@ MODULE_LICENSE("GPL and additional rights");
>> >  void intel_fbdev_output_poll_changed(struct drm_device *dev)
>> >  {
>> >     struct drm_i915_private *dev_priv = dev->dev_private;
>> > -   drm_fb_helper_hotplug_event(&dev_priv->fbdev->helper);
>> > +   if (dev_priv->fbdev)
>> > +           drm_fb_helper_hotplug_event(&dev_priv->fbdev->helper);
>> >  }
>>
>> Also intel_fbdev_restore_mode() needs the NULL fbdev safeguard.
>
> Fixed.

I still don't get why we need this check - for CONFIG_FB=n we have a
special dummy function and we are really careful in the setup code to
only enable the interrupt handling code once fbdev is fully set up. Or
do I miss some change here which makes this required? If so the right
fix imo would be to shuffle the init sequence again (and update all
the tons of comments about it, ofc).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch