[Intel-gfx] [PATCH 1/3] [VPG HSW-A] drm/i915: Add aspect ratio in drm_display_mode

[Daniel Vetter]

Re-adding dri-devel.

On Wed, Dec 18, 2013 at 2:02 PM, Vandana Kannan
<vandana.kannan at intel.com> wrote:
>>> @@ -177,6 +180,8 @@ struct drm_display_mode {
>>>
>>>      int vrefresh;           /* in Hz */
>>>      int hsync;              /* in kHz */
>>> +
>>> +    enum hdmi_picture_aspect picture_aspect_ratio;
>>>  };
>>
>> I'm not sure we want to bloat drm_display_mode with additional
>> junk for the sake of CEA modes. We could perhaps just have a
>> separate VIC indexed array for the aspect ratio information.
>>
>> At the very least we don't want to modify DRM_MODE() since that makes
>> this patch needlessly large, and makes DRM_MODE() even harder to decode
>> for humans. Instead you can just use c99 initializers and do it like so:
>>
>>   { DRM_MODE(...),
>>     .picture_aspect_ratio = x },
> I am working on making changes such that cea_modes looks like
>    { DRM_MODE(...),
>      .picture_aspect_ratio = x },
> Will push the patch soon. Please let me know if there are any concerns.

Ville's on vacation, but imo this makes sense. Also wrt process when
doing core drm changes (i.e. anything touching files outside of
drm/i915) then please always cross-post to dri-devel for discussions
and patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch