[Intel-gfx] [PATCH 3/6] drm/i915: reset eDP timestamps on resume

Jesse Barnes jbarnes at virtuousgeek.org
Thu Dec 19 18:35:11 CET 2013


On Thu, 19 Dec 2013 14:29:41 -0200
Paulo Zanoni <przanoni at gmail.com> wrote:

> +	 * Reset everything, otherwise when suspend/resume gets very fast, we
> +	 * delay the resume based on the values that were set when we were still
> +	 * suspending.
> +	 */
> +	intel_dp->last_power_on = tmp_jiffies - intel_dp->backlight_on_delay;
> +	intel_dp->last_power_cycle = tmp_jiffies -
> +				     intel_dp->panel_power_cycle_delay;
> +	intel_dp->last_backlight_off = tmp_jiffies -
> +				       intel_dp->backlight_off_delay;

I'm not clear on this; aren't the _delay fields in ms?  Here you're
subtracting ms units from jiffies units.  Don't you have to convert?
Or did I miss a unit change in an earlier patch?

Thanks,
Jesse



More information about the Intel-gfx mailing list