[Intel-gfx] [PATCH v2] drm/i915: clarify logging about reasons for disabling FBC

[Chris Wilson]

On Tue, Feb 19, 2013 at 09:18:20AM +0200, Jani Nikula wrote:
> Previously FBC disabling due to per-chip default was logged as being
> disabled per module parameter. Distinguish between the two.
> 
> v2: Don't even squawk in the debug log if FBC is explicitly disabled (Chris
> Wilson).

I'm still not entirely happy, as I still get to see the repeated message
many time a second, but it is an improvement over the current message.

I would be happiest if just the state changes were logged. Something
like in out_disable:
 if (reason != dev_priv->no_fbc_reason) {
   DEBUG("disabling fbc: %s\n", reason);
   dev_priv->no_fbc_reason = reason;
 }
and move the enum->string conversion from debugfs and just store the
(static) string.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre