[Intel-gfx] [PATCH 1/2] drm/i915: Revert hdmp HDP pin checks

Daniel Vetter daniel at ffwll.ch
Fri Feb 22 12:10:02 CET 2013


On Fri, Feb 22, 2013 at 08:36:57AM +0000, Chris Wilson wrote:
> On Fri, Feb 22, 2013 at 12:53:04AM +0100, Daniel Vetter wrote:
> > This reverts
> > 
> > commit 8ec22b214d76773c9d89f4040505ce10f677ed9a
> > Author: Chris Wilson <chris at chris-wilson.co.uk>
> > Date:   Fri May 11 18:01:34 2012 +0100
> > 
> >     drm/i915/hdmi: Query the live connector status bit for G4x
> > 
> > and
> > 
> > commit b0ea7d37a8f63eeec5ae80b4a6403cfba01da02f
> > Author: Damien Lespiau <damien.lespiau at intel.com>
> > Date:   Thu Dec 13 16:09:00 2012 +0000
> > 
> >     drm/i915/hdmi: Read the HPD status before trying to read the EDID
> > 
> > They reliably cause HDMI to not be detected on some systems (like my
> > ivb or the bug reporters gm45). To fix up the very slow unplug issues
> > we might want to fire up a 2nd detect cycle a few hundred ms after
> > each hotplug. But for now at least make displays work again.
> > 
> > I somewhat suspect that this is confined to HDMI connectors, since all
> > the machines I have with DP+ outputs work correctly.
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=52361
> > Cc: Damien Lespiau <damien.lespiau at intel.com>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> I wish we had a solid explanation here, because the status bit sounds
> exactly what we need here. Reality is such a let down.

Yeah, it's a bit unsatisfactory since it seems to work on a lot of
machines. Dunno what exactly is going on here on the oddball ones.

> Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: stable at vger.kernel.org.kernel.org # for 8ec22b21

Patch merged.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list