[Intel-gfx] [PATCH] drm/i915: Fix a bogus cast in execbuffer2
ville.syrjala at linux.intel.com
ville.syrjala at linux.intel.com
Fri Feb 22 14:42:22 CET 2013
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
The pointer passed to copy_from_user() was cast to the wrong type. This
doesn't cause any issues, but it confuses the reader. Just cast to
void * like we do for the other execbuffer kernel<->user copies.
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 2f2daeb..9efe04f 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -1190,8 +1190,7 @@ i915_gem_execbuffer2(struct drm_device *dev, void *data,
return -ENOMEM;
}
ret = copy_from_user(exec2_list,
- (struct drm_i915_relocation_entry __user *)
- (uintptr_t) args->buffers_ptr,
+ (void __user *)(uintptr_t)args->buffers_ptr,
sizeof(*exec2_list) * args->buffer_count);
if (ret != 0) {
DRM_DEBUG("copy %d exec entries failed %d\n",
--
1.7.12.4
More information about the Intel-gfx
mailing list