[Intel-gfx] [PATCH 1/2] drm/i915: Created a sized object error dump

[Ben Widawsky]

On Sun, Feb 24, 2013 at 09:25:32AM +0000, Chris Wilson wrote:
> On Sat, Feb 23, 2013 at 05:30:09PM -0800, Ben Widawsky wrote:
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> > ---
> >  drivers/gpu/drm/i915/i915_irq.c | 18 +++++++++++-------
> >  1 file changed, 11 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> > index 29037e0..ebaf558 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -952,24 +952,25 @@ static void i915_get_extra_instdone(struct drm_device *dev,
> >  
> >  #ifdef CONFIG_DEBUG_FS
> >  static struct drm_i915_error_object *
> > -i915_error_object_create(struct drm_i915_private *dev_priv,
> > -			 struct drm_i915_gem_object *src)
> > +i915_error_object_create_sized(struct drm_i915_private *dev_priv,
> > +			       struct drm_i915_gem_object *src,
> > +			       int num_pages)
> >  {
> >  	struct drm_i915_error_object *dst;
> > -	int i, count;
> > +	int i;
> >  	u32 reloc_offset;
> >  
> >  	if (src == NULL || src->pages == NULL)
> >  		return NULL;
> >  
> > -	count = src->base.size / PAGE_SIZE;
> > +	num_pages = src->base.size / PAGE_SIZE;
> 
> Probably didn't mean to overwrite your new parameter with the old value.

Sorry, thanks. This was not in the version of the patch I tested.
-- 
Ben Widawsky, Intel Open Source Technology Center