[Intel-gfx] [PATCH 09/13] drm/i915: add reset_state for hw_contexts

[Jesse Barnes]

On Tue, 26 Feb 2013 17:47:12 -0800
Ian Romanick <idr at freedesktop.org> wrote:

> On 02/26/2013 03:05 AM, Mika Kuoppala wrote:
> > For arb-robustness, every context needs to have it's own
> > reset state tracking. Default context will be handled in a identical
> > way as the no-context case in further down in the patch set.
> > For no-context case, the reset state will be stored in
> > the file_priv part.
> >
> > v2: handle default context inside get_reset_state
> 
> This isn't the interface we want.  I already sent you the patches for 
> Mesa, and you seem to have completely ignored them.  Moreover, this 
> interface provides no mechanism to query for its existence (other than 
> relying on the kernel version), and no method to deprecate it.

Before you get all wound up about this, note that you're replying to a
kernel internal function, not the ioctl that will be exposed to Mesa...

-- 
Jesse Barnes, Intel Open Source Technology Center