[Intel-gfx] [PATCH 1/3] drm/i915; Protect intel_gen4_compute_offset_xtiled() against unknown pixel format

[Chris Wilson]

On Tue, 8 Jan 2013 12:13:50 +0100, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Dec 18, 2012 at 10:13:12PM +0000, Chris Wilson wrote:
> > If the pixel format is not known to the core helpers, it fills in the
> > fb->bits_per_pixel field as 0. This causes a fatal divide-by-zero OOPS
> > when we then try to calculate the tiled offset. This would not be a
> > problem, but that the core helpers do not know about the YUV planar
> > formats we use for sprites.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Do we still need this one with the s/fb->bits_per_pixel/pixel_size/ change
> in one of the later patches?

I don't believe so, we fixed up the only known issue in the sprite code,
and for the time being we only have rgb primary display planes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre