[Intel-gfx] [PATCH 09/33] drm/i915: VGACNTRL needs an offset on VLV

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Jan 25 13:21:16 CET 2013


On Thu, Jan 24, 2013 at 10:39:52PM +0100, Daniel Vetter wrote:
> On Thu, Jan 24, 2013 at 03:29:34PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We already have a switch since VGACNTRL moved around on pch-split
> platforms, too. To avoid confusion with different ways to select a given
> reg I think a static inline and explicit VLV_VGACNTRL is better. Static
> inline since with i915_redisable_vga and i915_disable_vga we already have
> two callers.

All right. The save/restore paths also touch VGACNTRL. I'll convert
those too, even if we don't use them for much longer w/ kms.

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list