[Intel-gfx] [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug

[Ville Syrjälä]

On Tue, Jan 29, 2013 at 08:52:36AM -0800, Ben Widawsky wrote:
> On Tue, 29 Jan 2013 09:54:18 +0100
> Daniel Vetter <daniel at ffwll.ch> wrote:
> 
> > On Tue, Jan 29, 2013 at 08:41:12AM +0000, Damien Lespiau wrote:
> > > On Mon, Jan 28, 2013 at 03:32:15PM -0800, Ben Widawsky wrote:
> > > > /sys/kernel/debug has more or less been the standard location of
> > > > debugfs for several years now. Other parts of DRM already use
> > > > this location, so we should as well.
> > > > 
> > > > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> > > 
> > > Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
> > 
> > Queued for -next, thanks for the patch. Oh and fixed up a bikeshed
> > from checkpatch.pl while applying:
> > 
> > Applying: drm/i915: Error state should print /sys/kernel/debug
> > WARNING: line over 80 characters
> > #22: FILE: drivers/gpu/drm/i915/i915_irq.c:1308:
> > +       DRM_INFO("capturing error event; look for more information
> > in /sys/kernel/debug/dri/%d/i915_error_state\n",
> > 
> > total: 0 errors, 1 warnings, 8 lines checked
> > 
> > Yeah, I've added that OCD thing to my patch apply pipeline, let's see
> > how much fun it is ;-)
> 
> I've not looked at the final patch yet, but I think breaking up
> constant strings is considered bad form, and lines above 80 are
> generally favored for grepability.
> 
> At least James Bottomley said that in his talk and LPC, and a bunch of
> other maintainers seemed to agree. (and I agree)

I routinely ignore the 80 cols warnings. I'm sure a significant part
of my patches violate it, even the ones w/o long strings.

-- 
Ville Syrjälä
Intel OTC