[Intel-gfx] [PATCH 4/4] drm/i915: add error_state sysfs entry

[Chris Wilson]

On Thu, Jun 06, 2013 at 05:38:54PM +0300, Mika Kuoppala wrote:
> As getting error state doesn't anymore require big kmallocs,
> make error state accessible also from sysfs.
> 
> v2: - error state clearing (Chris Wilson)
>     - user hint, proper access mode bits and name (Daniel Vetter)
> 
> v3: release resources in proper order (Chris Wilson)
> 
> Suggested-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

I am happy overall here. We could take the plunge and use this as an
excuse to move all the error-state string handling into a new file,
which would be useful for when we pull the hangcheck mechanism out of
i915_irq.c.

Perhaps the more pressing bikeshed is that after years of
i915_error_state, I'm tired of the name and think that the 'state' was
just redundant, so perhaps '/sys/class/drm/card0/error' is a nice
minimalist and modern looking name.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre