[Intel-gfx] [PATCH 29/66] drm: pre allocate node for create_block

[Ben Widawsky]

On Sun, Jun 30, 2013 at 02:34:43PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:30PM -0700, Ben Widawsky wrote:
> > For an upcoming patch where we introduce the i915 VMA, it's ideal to
> > have the drm_mm_node as part of the VMA struct (ie. it's pre-allocated).
> > Part of the conversion to VMAs is to kill off obj->gtt_space. Doing this
> > will break a bunch of code, but amongst them are 2 callers of
> > drm_mm_create_block(), both related to stolen memory.
> > 
> > As a side note, this patch has is able to leverage all the existing
> > drm_mm_put_block because the node is still kzalloc'd. When the
> > aforementioned VMA code comes into play, that too has to change.
> > 
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> Same here about cc'ing dri-devel. Furthermore I think it'd be nice to kill
> the interfaces from drm_mm.c which allocate the drm_mm_node themselves.
> The last user outside of drm/i915 is ttm, killing that one would also
> allow us to remove the (racy) preallocation madness.
> 
> So if you convert over all of drm/i915 to the preallcoate functions which
> pass in the drm_mm_node, I'll volunteer myself to fix up ttm.
> -Daniel

I will do that and send it as a separate series.
-- 
Ben Widawsky, Intel Open Source Technology Center