[Intel-gfx] [PATCH 23/66] drm/i915: Move stolen stuff to i915_gtt

[Daniel Vetter]

On Mon, Jul 1, 2013 at 8:43 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Sun, Jun 30, 2013 at 03:18:46PM +0200, Daniel Vetter wrote:
>> On Thu, Jun 27, 2013 at 04:30:24PM -0700, Ben Widawsky wrote:
>> > It doesn't apply to generic VMA, so it belongs with the gtt.
>> >
>> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
>> >     sed -i "s/mm.stolen_base/gtt.stolen_base/" $file;
>> > done
>> >
>> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
>> >     sed -i "s/mm.stolen/gtt.stolen/" $file;
>> > done
>> >
>> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
>>
>> Before I keep on merging I'd like to clarify the plan a bit: Afaics the
>> goal is to extract useful stuff shared between global gtt and ppgtt into
>> i915_address_space. But I'm a bit unclear what dev_priv->mm will hold in
>> the end, so I'm not sure whether moving stolen around makes sense.
>>
>> Can you please elaborate on your plan a bit on how dev_priv->gtt and
>> dev_priv->mm will relate in the end?
>>
>> Thanks, Daniel
>>
> This patch is leftover from when I completely removed mm. In the high
> level abstraction, the stolen memory belongs to the GTT, so I decided to
> keep it. There is no other reason for the patch. We can drop it of
> nobody likes it.

I think keeping the stolen allocator in ->mm makes more sense then,
since it doesn't stricly have anything to do with managing the global
gtt address space. If the linux memory hotplug support wouldn't be so
limited we could even hand out that block of RAM to the core page
allocator ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch