[Intel-gfx] [PATCH 1/3] drm/i915: clean up media reset on gm45

[Chris Wilson]

On Wed, Jul 03, 2013 at 10:36:21AM +0200, Daniel Vetter wrote:
> On Wed, Jul 03, 2013 at 09:22:49AM +0100, Chris Wilson wrote:
> > On Wed, Jul 03, 2013 at 10:07:56AM +0200, Daniel Vetter wrote:
> > > Originally I've thought that this fixes up the reset issues on my
> > > gm45, but that was just a red herring due to b0rked testing.
> > > 
> > > Still I much prefer writing the right values (all other fields are
> > > reserved) instead of potentially dragging gunk around. Hence also
> > > clear the register to 0 after a reset.
> > 
> > "reserved; mbz" or "reserved; do not modify" ?
> 
> "Reserved, Acccess: RO, Default value: 0" I guess that means we can't
> possible get something non-zero in there ...

Well they did leave that weasel word "default" in there... ;-)

But that is a little more convincing that we aren't going to clear
hidden state.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre