[Intel-gfx] [PATCH] drm/i915: less magic for stolen preallocated objects w/o gtt offset

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 4 12:41:43 CEST 2013


On Thu, Jul 04, 2013 at 12:22:34PM +0200, Daniel Vetter wrote:
> A magic -1 is a obscure, especially since it's actually passed as an
> unsigned, so depens upon the magic sign extension rules in C. This has
> been added in
> 
> commit 3727d55e4d85836aa6cb759a965daaef88074150
> Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> Date:   Wed May 8 10:45:14 2013 -0700
> 
>     drm/i915: allow stolen, pre-allocated objects to avoid GTT allocation v2
> 
> Use a proper #define instead. Spotted while reviewing Ben's
> drm_mm_create_block changes.

A 32bit number in a 32/64bit constant. So still a type mismatch in the
comparisons, just use ((u32)-1).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list