[Intel-gfx] [PATCH] drm/i915: less magic for stolen preallocated objects w/o gtt offset

[Daniel Vetter]

On Thu, Jul 04, 2013 at 12:31:37PM +0100, Chris Wilson wrote:
> On Thu, Jul 04, 2013 at 01:06:28PM +0200, Daniel Vetter wrote:
> > A magic -1 is a obscure, especially since it's actually passed as an
> > unsigned, so depens upon the magic sign extension rules in C. This has
> 
> s/depens/depends/.

Fixed ...
> 
> > been added in
> > 
> > commit 3727d55e4d85836aa6cb759a965daaef88074150
> > Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> > Date:   Wed May 8 10:45:14 2013 -0700
> > 
> >     drm/i915: allow stolen, pre-allocated objects to avoid GTT allocation v2
> > 
> > Use a proper #define instead. Spotted while reviewing Ben's
> > drm_mm_create_block changes.
> > 
> > v2: Cast the constant to u32 since otherwise we again have a type
> > mismatch. Suggested by Chris Wilson.
> > 
> > Cc: Ben Widawsky <ben at bwidawsk.net>
> > Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

... and merged, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch