[Intel-gfx] [PATCH 34/35] hack: Make fifo underruns DRM_ERROR

[Ville Syrjälä]

On Fri, Jul 05, 2013 at 02:19:59PM -0300, Paulo Zanoni wrote:
> 2013/7/5  <ville.syrjala at linux.intel.com>:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > Want to see them w/ debugs turned off.
> 
> And what about PCH FIFO underruns?

Ideally we'd want this patch, and yes, other underrun types too. But
I'm thinking that we don't want it before we have sufficient pixel
rate/bandwidth/etc. checks in place. I'm sure someone would file a
bug as soon as they see the error.

> > ---
> >  drivers/gpu/drm/i915/i915_irq.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> > index 10554bf..a55a231 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -1103,15 +1103,15 @@ static void ivb_err_int_handler(struct drm_device *dev)
> >
> >         if (err_int & ERR_INT_FIFO_UNDERRUN_A)
> >                 if (intel_set_cpu_fifo_underrun_reporting(dev, PIPE_A, true))
> > -                       DRM_DEBUG_DRIVER("Pipe A FIFO underrun\n");
> > +                       DRM_ERROR("Pipe A FIFO underrun\n");
> >
> >         if (err_int & ERR_INT_FIFO_UNDERRUN_B)
> >                 if (intel_set_cpu_fifo_underrun_reporting(dev, PIPE_B, true))
> > -                       DRM_DEBUG_DRIVER("Pipe B FIFO underrun\n");
> > +                       DRM_ERROR("Pipe B FIFO underrun\n");
> >
> >         if (err_int & ERR_INT_FIFO_UNDERRUN_C)
> >                 if (intel_set_cpu_fifo_underrun_reporting(dev, PIPE_C, true))
> > -                       DRM_DEBUG_DRIVER("Pipe C FIFO underrun\n");
> > +                       DRM_ERROR("Pipe C FIFO underrun\n");
> >
> >         I915_WRITE(GEN7_ERR_INT, err_int);
> >  }
> > @@ -1360,11 +1360,11 @@ static irqreturn_t ironlake_irq_handler(int irq, void *arg)
> >
> >         if (de_iir & DE_PIPEA_FIFO_UNDERRUN)
> >                 if (intel_set_cpu_fifo_underrun_reporting(dev, PIPE_A, true))
> > -                       DRM_DEBUG_DRIVER("Pipe A FIFO underrun\n");
> > +                       DRM_ERROR("Pipe A FIFO underrun\n");
> >
> >         if (de_iir & DE_PIPEB_FIFO_UNDERRUN)
> >                 if (intel_set_cpu_fifo_underrun_reporting(dev, PIPE_B, true))
> > -                       DRM_DEBUG_DRIVER("Pipe B FIFO underrun\n");
> > +                       DRM_ERROR("Pipe B FIFO underrun\n");
> >
> >         if (de_iir & DE_PLANEA_FLIP_DONE) {
> >                 intel_prepare_page_flip(dev, 0);
> > --
> > 1.8.1.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> 
> 
> -- 
> Paulo Zanoni

-- 
Ville Syrjälä
Intel OTC