[Intel-gfx] [PATCH] drm/i915: fix up ring cleanup for the i830/i845 CS tlb w/a

Chris Wilson chris at chris-wilson.co.uk
Sat Jul 6 00:53:41 CEST 2013


On Fri, Jul 05, 2013 at 11:39:50PM +0200, Daniel Vetter wrote:
> It's not a good idea to also run the pipe_control cleanup.
> 
> This regression has been introduced whith the original cs tlb w/a in
> 
> commit b45305fce5bb1abec263fcff9d81ebecd6306ede
> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
> Date:   Mon Dec 17 16:21:27 2012 +0100
> 
>     drm/i915: Implement workaround for broken CS tlb on i830/845
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64610
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: stable at vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Just promise me on the next ring->private, we will add a real
destructor.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list