[Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file
Ben Widawsky
ben at bwidawsk.net
Fri Jul 12 19:56:55 CEST 2013
On Fri, Jul 12, 2013 at 06:08:22PM +0100, Chris Wilson wrote:
> Currently, the register access code is split between i915_drv.c and
> intel_pm.c. It only bares a superficial resemblance to the reset of the
> powermanagement code, so move it all into its own file. This is to ease
> further patches to enforce serialised register access.
>
> v2: Scan for random abuse of I915_WRITE_NOTRACE
> v3: Take the opportunity to rename the GT functions as uncore. Uncore is
> the term used by the hardware design (and bspec) for all functions
> outside of the GPU (and CPU) cores in what is also known as the System
> Agent.
>
Bikesheds:
Would have preferred the gt/pm_init split as a separate patch.
intel_uncore_clear_errors/chec_errors seems silly to me.
Acked-by: Ben Widawsky <ben at bwidawsk.net>
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list