[Intel-gfx] [PATCH 8/9] drm/i915: Restore ILK powerctx pin attributes

Ben Widawsky ben at bwidawsk.net
Mon Jul 15 19:58:57 CEST 2013


On Mon, Jul 15, 2013 at 11:30:15AM +0100, Chris Wilson wrote:
> On Sun, Jul 14, 2013 at 09:22:52AM -0700, Ben Widawsky wrote:
> > Now that I've killed renderctx, and the ILK pm code no longer has
> > anything shared with the regular i915 context code, make the pin
> > arguments the same as how they were before I started.
> > 
> > I do not know the reason for the original pin arguments, so it's totally
> > possible this commit isn't necessary (and conversely that I temporarily
> > broke things earlier in the patch series; though I saw no such result).
> > However, since ILK RC6 worked very well for those of us where it worked,
> > I think messing with any of the code is unjustified.
> 
> We should move it out of the aperture as there is no reason for this to
> be GTT accessible. That requires an extra patch to request top-down
> allocation.
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

I am perfectly fine with dropping this patch, which I think solves the
problem. I see no reason to go back to a 4k aligned alloc, do you?

-- 
Ben Widawsky, Intel Open Source Technology Center



More information about the Intel-gfx mailing list