[Intel-gfx] [PATCH 07/11] drm/i915: add update function to disable/enable-back PSR

[Rodrigo Vivi]

On Mon, Jul 15, 2013 at 11:00 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Thu, Jul 11, 2013 at 06:45:01PM -0300, Rodrigo Vivi wrote:
>> @@ -1602,6 +1611,26 @@ void intel_edp_psr_disable(struct intel_dp *intel_dp)
>>               DRM_ERROR("Timed out waiting for PSR Idle State\n");
>>  }
>>
>> +void intel_edp_psr_update(struct drm_device *dev)
>> +{
>> +     struct intel_encoder *encoder;
>> +     struct intel_dp *intel_dp = NULL;
>> +
>> +     list_for_each_entry(encoder, &dev->mode_config.encoder_list, base.head)
>> +             if (encoder->type == INTEL_OUTPUT_EDP) {
>
> How many eDP are you planning to allow on the system? We already have
> precedence for the presumption of a single (integrated) panel on a device,
> maybe we can add the logic there (i.e. stash a back pointer in this case)?

That is a good question... I asked it myself many times when I was
trying to get intel_dp with edp from dev...
For the first version I just run the loop getting any intel_dp with
edp since we have this assumption of only one edp,
but then I thought about that convertibles with 2 panels and since in
hsw we can have edp on port D I decided to let the implementation
more generic as possible although I know we won't have this case... at
least not any time soon.

>
> We could then also do a debugfs/i915_panel_info where we can inspect
> various details normally associated with the panels (PSR status, backlight
> interface, eDP vs LVDS, etc).

I liked this idea... will have in mind for later

> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre

Thanks

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br