[Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 17 23:08:34 CEST 2013


On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote:
> On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote:
> >> Hi Chris,
> >>
> >> could you please review this specific one or give you ack here?
> >
> > Didn't see anything wrong with it. The only caveat I have is that the
> > GETPARAM must be accurate immediately following a setcrtc.
> 
> To be truly honest I have no idea, mainly when we alternate with fbcon
> updating psr state at set_base.
> Could you please also review subsequent patches in this series... 10 and 11.
> I think 11 answer this question...

If it is not clear by this point, and the changelog doesn't make it
clear, then something is missing from this patch. Hint ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list