[Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

Jesse Barnes jbarnes at virtuousgeek.org
Thu Jul 18 18:18:34 CEST 2013


On Thu, 18 Jul 2013 16:19:07 +0100
Damien Lespiau <damien.lespiau at intel.com> wrote:

> This will allow us to explicitely blacklist tests we don't want to run
> on simulation.

So FWIW I'll reiterate that I'd prefer to manage this in either the
Makefile target for the tests (e.g. have a single_kernel_sim_tests or
somesuch), or separate scripts altogether for running the different
types of tests, with specific subsets for running on simulation.

Having to sprinkle skip_on_simulation into the actual tests seems like
duplicated effort across every test.

For the cases where the args or iterations differ, it might be better
to simply take an argv for the values, and have the sim vs. full
scripts pass different values.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list