[Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

[Daniel Vetter]

On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote:
> On Thu, 18 Jul 2013 16:19:07 +0100
> Damien Lespiau <damien.lespiau at intel.com> wrote:
> 
> > This will allow us to explicitely blacklist tests we don't want to run
> > on simulation.
> 
> So FWIW I'll reiterate that I'd prefer to manage this in either the
> Makefile target for the tests (e.g. have a single_kernel_sim_tests or
> somesuch), or separate scripts altogether for running the different
> types of tests, with specific subsets for running on simulation.

We have lots of tests with subtests, and sometimes we might want to
exclude just a few of them, not all. Doing that at the Makefile level is a
bit too coarse imo.

> Having to sprinkle skip_on_simulation into the actual tests seems like
> duplicated effort across every test.
> 
> For the cases where the args or iterations differ, it might be better
> to simply take an argv for the values, and have the sim vs. full
> scripts pass different values.

We have tons of tests meanwhile, if you want to run them with piglit
passing individual options with argv for each test doesn't scale better
imo than just baking those into the tests.

It's gonna suck a bit one way or the other I guess :(
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch