[Intel-gfx] [PATCH 2/3] drm/i915: add debug info in slow path

[Daniel Vetter]

On Fri, Jul 19, 2013 at 01:51:25PM +0800, Xiong Zhang wrote:
> Signed-off-by: Xiong Zhang <xiong.y.zhang at intel.com>

I guess this was useful for debugging, but printks are rather expensive.
So I'll drop this - if we ever decide that this is useful information we
could expose it as a tracepoint, but since not even the core file i/o path
has that I don't think we need it.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_gem.c            | 4 ++++
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index de59154..f194d7e 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -376,6 +376,8 @@ shmem_pread_slow(struct page *page, int shmem_page_offset, int page_length,
>  	char *vaddr;
>  	int ret;
>  
> +	DRM_DEBUG("execute pread slow path\n");
> +
>  	vaddr = kmap(page);
>  	if (needs_clflush)
>  		shmem_clflush_swizzled_range(vaddr + shmem_page_offset,
> @@ -689,6 +691,8 @@ shmem_pwrite_slow(struct page *page, int shmem_page_offset, int page_length,
>  	char *vaddr;
>  	int ret;
>  
> +	DRM_DEBUG("execute pwrite slow path\n");
> +
>  	vaddr = kmap(page);
>  	if (unlikely(needs_clflush_before || page_do_bit17_swizzling))
>  		shmem_clflush_swizzled_range(vaddr + shmem_page_offset,
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 1734825..3065297 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -587,6 +587,7 @@ i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
>  	int i, total, ret;
>  	int count = args->buffer_count;
>  
> +	DRM_DEBUG("Execute relocate slow path\n");
>  	/* We may process another execbuffer during the unlock... */
>  	while (!list_empty(&eb->objects)) {
>  		obj = list_first_entry(&eb->objects,
> -- 
> 1.8.3.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch