[Intel-gfx] [PATCH 02/10] drm/i915: extract ilk_display_irq_handler

[Daniel Vetter]

On Fri, Jul 19, 2013 at 11:24:21AM -0300, Paulo Zanoni wrote:
> 2013/7/19 Mika Kuoppala <mika.kuoppala at linux.intel.com>:
> > Paulo Zanoni <przanoni at gmail.com> writes:
> >
> >> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >>
> >> It's the code that deals with de_iir.
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >
> > Minor observation on the whole irq stuff: ilk, ironlake and ivb,
> > ivybridge are both used and I couldn't figure out the pattern.
> 
> You mean the function names, right? This is something that confuses me
> too, all our code is inconsistent and I'd like to know what's the
> preferred way. We seem to use both ways: vlv_find_best_dpll vs
> valleyview_crtc_enable, ironlake_crtc_mode_set vs ilk_update_plane,
> haswell_modeset_global_resources vs ivb_modeset_global_resources. I
> tend to prefer the shorter versions because I believe these acronyms
> should be obvious (or easy to discover) for people reading our code,
> but having some guidance on which one to use on each case would be
> good. Opinions?

I prefer the shorter ones, too. But iirc Jesse is liking the longer ones
more, at least he tends to use them in his patches. I guess we'll just
have to flag this in patches. New fodder for a good bikeshd ;-)

Cheeers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch