[Intel-gfx] [PATCH 02/12] drm/i915: Fix up map and fenceable for VMA

[Ben Widawsky]

On Tue, Jul 23, 2013 at 06:42:35PM +0200, Daniel Vetter wrote:
> On Sun, Jul 21, 2013 at 07:08:09PM -0700, Ben Widawsky wrote:
> > formerly: "drm/i915: Create VMAs (part 3.5) - map and fenceable
> > tracking"
> > 
> > The map_and_fenceable tracking is per object. GTT mapping, and fences
> > only apply to global GTT. As such,  object operations which are not
> > performed on the global GTT should not effect mappable or fenceable
> > characteristics.
> > 
> > Functionally, this commit could very well be squashed in to the previous
> > patch which updated object operations to take a VM argument.  This
> > commit is split out because it's a bit tricky (or at least it was for
> > me).
> > 
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> 
> On a quick read there seems to be lots of stuff in here which belongs into
> other patches, like error handling changes, debugfs changes. At least
> since you claim that the mappable/fenceable stuff is tricky it seems to
> not stick out that much ...

Yep. I can't remember if I intentionally squashed this, and didn't
update the commit, or accidentally squashed it. In either case, you're
right.
-- 
Ben Widawsky, Intel Open Source Technology Center